Skip to content

fix: key error for storage name#28

Merged
drobnikj merged 2 commits intomasterfrom
fix/storage_name
Jan 20, 2023
Merged

fix: key error for storage name#28
drobnikj merged 2 commits intomasterfrom
fix/storage_name

Conversation

@drobnikj
Copy link
Copy Markdown
Member

@drobnikj drobnikj commented Jan 19, 2023 •
edited
Loading

fix KeyError: 'name', when the name is not presented in dict.

disclaimer: this is my first pr in python 😄
@drobnikj drobnikj marked this pull request as ready for review January 19, 2023 15:44
fnesveda
fnesveda approved these changes Jan 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, good catch! 🚀
@github-actions github-actions Bot added this to the 55th sprint - Platform team milestone Jan 20, 2023
@github-actions github-actions Bot added the t-core-services Issues with this label are in the ownership of the core services team. label Jan 20, 2023
@drobnikj drobnikj merged commit 83b30a9 into master Jan 20, 2023
@drobnikj drobnikj deleted the fix/storage_name branch January 20, 2023 08:39
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-core-services Issues with this label are in the ownership of the core services team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

3 participants

@drobnikj @jirimoravcik @fnesveda