Avoid extra normalization#71
Merged
karimnosseir merged 1 commit intoJul 1, 2026
Merged
Conversation
srjoglekar246
approved these changes
Jul 1, 2026
Avoid softmax on all experts and extra normalization. Perf impact is tiny ~2% improvement on decode Testing: presubmit
karimnosseir
force-pushed
the
user/karimnosseir/mixtral_expert_select_opt
branch
from
8818c3f to
83e80bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid softmax on all experts and extra normalization.
Perf impact is tiny ~2% improvement on decode
Testing: presubmit