Open
Conversation
rnro
force-pushed
the
expose_bytebuffer_allocator
branch
from
93d5e32 to
661bfc5
Compare
Motivation * Other libraries often have byte buffer storage with similar concepts as NIO's `ByteBuffer`, linear storage with reader and writer indices - it would be nice to have efficient conversion to and from these objects. * Efficienct conversion would likely mean taking ownership of the byte storage allocated by the other object and exposing `ByteBuffer`s internals so that they may be owned by another object, there is no API for this currently. Modifications * Added new methods behind `CustomByteBufferAllocator` SPI. * Added public `ByteBuffer` initializer for adopting externally-allocated memory * Made `ByteBufferAllocator` initializer public with custom `malloc`/`realloc`/`free`/`memcpy` hooks * Updated `realloc` signature to pass old capacity alongside new capacity to allow implementations to copy over bytes * Added `withVeryUnsafeMutableBytesWithStorageManagement` for mutable storage access * Updated all existing tests using internal allocator API to use the new API * Added tests for custom allocator functionality Result * Custom allocators can manage `ByteBuffer` memory with full size information * External systems can transfer memory ownership to `ByteBuffer` * System allocator maintains zero overhead due to inlining of the wrapper * API (SPI) is extensible for future allocation system integrations
rnro
force-pushed
the
expose_bytebuffer_allocator
branch
from
661bfc5 to
0e0f89e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ByteBuffer, linear storage with reader and writer indices - it would be nice to have efficient conversion to and from these objects.ByteBuffers internals so that they may be owned by another object, there is no API for this currently.Modifications
CustomByteBufferAllocatorSPI.ByteBufferinitializer for adopting externally-allocated memoryByteBufferAllocatorinitializer public with custommalloc/realloc/free/memcpyhooksreallocsignature to pass old capacity alongside new capacity to allow implementations to copy over byteswithVeryUnsafeMutableBytesWithStorageManagementfor mutable storage accessResult
ByteBuffermemory with full size informationByteBuffer