fix(stdio): redact config values in "Configuration loaded" log - #788
Open
cosmic-fire-eng wants to merge 1 commit into
Open
fix(stdio): redact config values in "Configuration loaded" log#788cosmic-fire-eng wants to merge 1 commit into
cosmic-fire-eng wants to merge 1 commit into
Conversation
On stdio startup the generated bootstrap logged the full parsed config object to stderr. When a server's config schema carries credentials, those secrets are written in plaintext to every sink that captures the process stderr (systemd/journald, docker logs, log shippers). Log only the config keys, which still satisfies the "what did I parse" diagnostic this line exists for. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
Checking in here — since this touches credential logging I wanted to keep it on your radar. Happy to rebase onto latest or move the redaction point if you'd prefer a different approach. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On stdio startup the generated bootstrap logs the full parsed config object to stderr. When a server's config schema carries credentials, those secrets are written in plaintext to every sink that captures the process stderr (systemd/journald, docker logs, log shippers).
Concrete case: a server whose
configSchemais{ email, password, mfaSecret }prints all three at launch. Because the leak is in the shared stdio runtime template, it affects every TypeScript-runtime Smithery MCP whose config carries secrets. The keys alone satisfy the "what did I parse" diagnostic this line exists for, so this logsObject.keys(config)and drops the values.shttp-bootstrap.tsdoes not log config, so no change there.