Skip to content

feat: myaccount API support - #136

Merged
rmad17 merged 4 commits into
passkey-supportfrom
myaccount-support
Jul 21, 2026
Merged

feat: myaccount API support#136
rmad17 merged 4 commits into
passkey-supportfrom
myaccount-support

Conversation

@rmad17

@rmad17 rmad17 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

📋 Changes

This PR carves the My Account API slice out of #116, which combined Passkey, My Account, and DPoP into one large diff. It's the second of three sequential branches (Passkey → My Account → DPoP), split for merge-conflict legibility.

Refer to #116 for the original review discussion and feedback — the code here was reviewed there; this PR only re-sequences it.

Features

  • My Account API — Authentication Methods & Factors (MyAccountClient): get_factors, list_authentication_methods, get_authentication_method, delete_authentication_method, update_authentication_method, enroll_authentication_method, and verify_authentication_method. Lets
    a logged-in user manage their own enrolled authentication methods (passkey, email, phone, TOTP, push, recovery-code, password) against the My Account API,
    scoped by fine-grained scopes like read:me:factors.
  • Enrollment and verification are generic across method types — the type is set via EnrollAuthenticationMethodRequest.type, not a dedicated method per type.

API Changes

  • New public methods on MyAccountClient: get_factors, list_authentication_methods, get_authentication_method, delete_authentication_method, update_authentication_method,
    enroll_authentication_method, verify_authentication_method.
  • New public models: Factor, GetFactorsResponse, AuthenticationMethod, ListAuthenticationMethodsResponse, EnrollAuthenticationMethodRequest, EnrollmentChallengeResponse, VerifyAuthenticationMethodRequest, UpdateAuthenticationMethodRequest, plus type aliases EnrollmentType
    and PreferredAuthMethod.
  • No new error types — these methods raise the existing MyAccountApiError/ ApiError / MissingRequiredArgumentError, consistent with the rest of MyAccountClient.
  • New doc: examples/MyAccountAuthenticationMethods.md
    (prerequisites, obtaining a scoped token, all six operations, error handling). README gains a linking section; Passkeys.md gains a cross-reference note pointing here for passkey management (as opposed to passkey sign-in).
@rmad17
rmad17 requested a review from a team as a code owner July 20, 2026 06:24
@rmad17 rmad17 changed the title feat: Myaccount API support Jul 20, 2026
@rmad17
rmad17 changed the base branch from main to passkey-support July 20, 2026 10:33
@rmad17
rmad17 requested a review from kishore7snehil July 20, 2026 14:06

@kishore7snehil kishore7snehil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Added dpop support for myaccount and passkeys
@rmad17
rmad17 merged commit 348b327 into passkey-support Jul 21, 2026
7 checks passed
@rmad17
rmad17 deleted the myaccount-support branch July 21, 2026 08:55
@rmad17 rmad17 mentioned this pull request Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants