Skip to content

Conversation

@mprimeaux
Copy link

@mprimeaux mprimeaux commented Nov 22, 2025

A Deterministic Random Bit Generator based on AES in Counter mode (AES-CTR-DRBG) as specified in NIST SP 800-90A written in Go.

Please note this library was part of nanoid but decided to move it to its own repository along with the related prng-chacha module.

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

  • The packages around my addition still meet the Quality Standards.

Of the packages above and below this entry, the only package that may need further review is acmetool as it has not received a commit in 3 years (January 8, 2023) as of when this PR was submitted.

Thanks for your PR, you're awesome! 😎

Summary by CodeRabbit

  • Documentation
    • Added a new security library entry (aes-ctr-drbg) to the README, documenting a Deterministic Random Bit Generator implementation based on the NIST SP 800-90A standard.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 22, 2025

Walkthrough

A new security library entry for aes-ctr-drbg (Deterministic Random Bit Generator based on AES-CTR-DRBG conforming to NIST SP 800-90A) was added to the Security section of the README.md file.

Changes

Cohort / File(s) Summary
Documentation Update
README.md
Added new library entry aes-ctr-drbg under the Security section, documenting a NIST SP 800-90A compliant deterministic random bit generator.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A new guard in the security row,
AES-CTR-DRBG steals the show!
NIST-approved, randomness so fine,
Documentation dance—all in line! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and accurately describes the main change: adding a new library entry for AES-CTR-DRBG, a Deterministic Random Bit Generator. It is specific, concise, and directly matches the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mprimeaux
Copy link
Author

The code coverage as of this PR is approximately 88.4% as per the README reference to SonarCloud.

Screenshot 2025-11-22 at 10 49 30
@github-actions
Copy link

Automated Quality Checks (from CONTRIBUTING minimum standards)

  • Repo: OK
  • pkg.go.dev: OK
  • goreportcard: OK (grade unknown)
  • coverage: missing

These checks are a best-effort automation and do not replace human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant