Skip to content

Conversation

@stv0g
Copy link
Contributor

@stv0g stv0g commented Dec 16, 2025

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

  • forge link (github.com, gitlab.com, etc):
  • pkg.go.dev:
  • goreportcard.com:
  • coverage service link (codecov, coveralls, etc.):

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.
  • I removed the following packages around my addition: (please give a short reason for each removal)

Thanks for your PR, you're awesome! 😎

Summary by CodeRabbit

  • Documentation
    • Updated a testing library reference link in the README.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link

Automated Quality Checks (from CONTRIBUTING minimum standards)

  • Repo link: missing
  • pkg.go.dev: missing
  • goreportcard: missing
  • coverage: missing

These checks are a best-effort automation and do not replace human review.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Walkthrough

The README's Libraries for testing section was updated to replace the GitHub URL for the Gont library with its Codeberg equivalent. The project name and description remain unchanged.

Changes

Cohort / File(s) Summary
Documentation update
README.md
Gont library reference URL updated from GitHub (https://github.com/stv0g/gont) to Codeberg (https://codeberg.org/stv0g/gont); project name and description preserved

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Verify the new Codeberg URL is correct and accessible
  • Confirm URL formatting and markdown syntax are preserved

Poem

🐰 A link once pointed to GitHub's shore,
Now hops to Codeberg—a new door!
Same project, same name, so true,
Just shifted homes to somewhere new. 🔗

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating a link (Gont) to its new repository location, which aligns with the summary showing a URL migration from GitHub to Codeberg.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6baf327 and 3928194.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
README.md

📄 CodeRabbit inference engine (AGENTS.md)

README.md: When modifying the Awesome list, keep categories with at least three entries
Descriptions in the Awesome list must end with a period
Avoid promotional copy; keep descriptions concise and neutral in the Awesome list
Do not remove existing list content unless removal is requested and justified

Files:

  • README.md
**/*.md

📄 CodeRabbit inference engine (AGENTS.md)

Keep documentation in English

Files:

  • README.md
{README.md,COVERAGE.md}

📄 CodeRabbit inference engine (AGENTS.md)

Align rendered documentation (README.md, COVERAGE.md, etc.) with behavior changes in main.go or helper packages

Files:

  • README.md
🧠 Learnings (2)
📚 Learning: 2025-10-08T00:38:13.132Z
Learnt from: CR
Repo: avelino/awesome-go PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-10-08T00:38:13.132Z
Learning: Applies to **/*.go : Favor small, testable functions in Go

Applied to files:

  • README.md
📚 Learning: 2025-10-08T00:38:13.132Z
Learnt from: CR
Repo: avelino/awesome-go PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-10-08T00:38:13.132Z
Learning: Applies to **/*.go : Maintain ≥80% coverage for non-data packages and ≥90% for data packages when adding new testable Go code

Applied to files:

  • README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
README.md (1)

2471-2471: Gont URL update looks correct and guideline-compliant

The link now points to the new Codeberg location while keeping the entry’s description, punctuation, and alphabetical placement intact. No further changes needed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- [gomatch](https://github.com/jfilipczyk/gomatch) - library created for testing JSON against patterns.
- [gomega](https://onsi.github.io/gomega/) - Rspec like matcher/assertion library.
- [Gont](https://github.com/stv0g/gont) - Go network testing toolkit for testing building complex network topologies using Linux namespaces.
- [Gont](https://codeberg.org/stv0g/gont) - Go network testing toolkit for testing building complex network topologies using Linux namespaces.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Hardcoded GitHub URL parsing in test and validation scripts fails for the new Codeberg repository link, causing automated checks to be silently skipped or to fail.
Severity: HIGH | Confidence: High

🔍 Detailed Analysis

The change of a repository URL from GitHub to Codeberg in the README file introduces a bug in the automated validation infrastructure. The Go test file stale_repositories_test.go contains functions like checkRepoAvailability() that construct GitHub API URLs by replacing "https://github.com" in the link. This logic fails for the new Codeberg URL, resulting in malformed API calls and causing the staleness check for that repository to be silently skipped. Similarly, a JavaScript quality check script, .github/scripts/check-quality.js, uses a regex that only validates GitHub, GitLab, and Bitbucket URLs, which will cause it to reject future submissions that use Codeberg links.

💡 Suggested Fix

Refactor the URL parsing logic in stale_repositories_test.go to correctly extract the owner and repository from different hosting platforms, not just GitHub. Also, update the regex in .github/scripts/check-quality.js to include codeberg.org as a valid repository provider to prevent future PR quality checks from failing.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: README.md#L2471

Potential issue: The change of a repository URL from GitHub to Codeberg in the README
file introduces a bug in the automated validation infrastructure. The Go test file
`stale_repositories_test.go` contains functions like `checkRepoAvailability()` that
construct GitHub API URLs by replacing `"https://github.com"` in the link. This logic
fails for the new Codeberg URL, resulting in malformed API calls and causing the
staleness check for that repository to be silently skipped. Similarly, a JavaScript
quality check script, `.github/scripts/check-quality.js`, uses a regex that only
validates GitHub, GitLab, and Bitbucket URLs, which will cause it to reject future
submissions that use Codeberg links.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7595893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment