-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Update Gont link to new repository location #5960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Automated Quality Checks (from CONTRIBUTING minimum standards)
These checks are a best-effort automation and do not replace human review. |
WalkthroughThe README's Libraries for testing section was updated to replace the GitHub URL for the Gont library with its Codeberg equivalent. The project name and description remain unchanged. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (3)README.md📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.md📄 CodeRabbit inference engine (AGENTS.md)
Files:
{README.md,COVERAGE.md}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (2)📚 Learning: 2025-10-08T00:38:13.132ZApplied to files:
📚 Learning: 2025-10-08T00:38:13.132ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| - [gomatch](https://github.com/jfilipczyk/gomatch) - library created for testing JSON against patterns. | ||
| - [gomega](https://onsi.github.io/gomega/) - Rspec like matcher/assertion library. | ||
| - [Gont](https://github.com/stv0g/gont) - Go network testing toolkit for testing building complex network topologies using Linux namespaces. | ||
| - [Gont](https://codeberg.org/stv0g/gont) - Go network testing toolkit for testing building complex network topologies using Linux namespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Hardcoded GitHub URL parsing in test and validation scripts fails for the new Codeberg repository link, causing automated checks to be silently skipped or to fail.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The change of a repository URL from GitHub to Codeberg in the README file introduces a bug in the automated validation infrastructure. The Go test file stale_repositories_test.go contains functions like checkRepoAvailability() that construct GitHub API URLs by replacing "https://github.com" in the link. This logic fails for the new Codeberg URL, resulting in malformed API calls and causing the staleness check for that repository to be silently skipped. Similarly, a JavaScript quality check script, .github/scripts/check-quality.js, uses a regex that only validates GitHub, GitLab, and Bitbucket URLs, which will cause it to reject future submissions that use Codeberg links.
💡 Suggested Fix
Refactor the URL parsing logic in stale_repositories_test.go to correctly extract the owner and repository from different hosting platforms, not just GitHub. Also, update the regex in .github/scripts/check-quality.js to include codeberg.org as a valid repository provider to prevent future PR quality checks from failing.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: README.md#L2471
Potential issue: The change of a repository URL from GitHub to Codeberg in the README
file introduces a bug in the automated validation infrastructure. The Go test file
`stale_repositories_test.go` contains functions like `checkRepoAvailability()` that
construct GitHub API URLs by replacing `"https://github.com"` in the link. This logic
fails for the new Codeberg URL, resulting in malformed API calls and causing the
staleness check for that repository to be silently skipped. Similarly, a JavaScript
quality check script, `.github/scripts/check-quality.js`, uses a regex that only
validates GitHub, GitLab, and Bitbucket URLs, which will cause it to reject future
submissions that use Codeberg links.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7595893
We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.
Please provide some links to your package to ease the review
Pull Request content
Category quality
Note that new categories can be added only when there are 3 packages or more.
Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.
Please delete one of the following lines:
Thanks for your PR, you're awesome! 😎
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.