Skip to content

Screensaver slide animation instead of popin#4815

Closed
ieocin wants to merge 1 commit intobasecamp:devfrom
ieocin:patch-1
Closed

Screensaver slide animation instead of popin#4815
ieocin wants to merge 1 commit intobasecamp:devfrom
ieocin:patch-1

Conversation

@ieocin
Copy link

@ieocin ieocin commented Feb 28, 2026

When omarchy-cmd-screensaver finishes or is interrupted, hyprlands slide animation looks more polished - in my opinion - than the popin animation.

Copilot AI review requested due to automatic review settings February 28, 2026 16:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Hyprland window rules so the Omarchy screensaver uses a slide animation rather than the default popin behavior when it appears/disappears.

Changes:

  • Adds a Hyprland windowrule to apply animation slide to the org.omarchy.screensaver window class.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

windowrule = opacity 0.97 0.9, match:tag default-opacity

# Sliding animation for the screensaver instead of popin
windowrule = animation slide, match:class org.omarchy.screensaver
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match:class is treated as a regex in this config (e.g., other rules use .*, ^$, etc.). As written, org.omarchy.screensaver will treat . as “any character” and can match unintended classes. Escape the dots and (ideally) anchor it to an exact match, consistent with other exact-match rules.

Suggested change
windowrule = animation slide, match:class org.omarchy.screensaver
windowrule = animation slide, match:class ^org\.omarchy\.screensaver$
Copilot uses AI. Check for mistakes.
Comment on lines +16 to +18

# Sliding animation for the screensaver instead of popin
windowrule = animation slide, match:class org.omarchy.screensaver
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an app-specific rule, but it’s being added to windows.conf even though the file already delegates app-specific tweaks via source = .../apps.conf and org.omarchy.screensaver rules currently live in default/hypr/apps/system.conf. Consider moving this rule alongside the other screensaver rules so related behavior stays grouped and easier to maintain.

Suggested change
# Sliding animation for the screensaver instead of popin
windowrule = animation slide, match:class org.omarchy.screensaver
Copilot uses AI. Check for mistakes.
@dhh dhh closed this in 42e2087 Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants