Expand FileRoot to its exec path in command lines
#28074
+132
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, `FileRoot` objects were stringified to their absolute (!) path with a `derived/source` suffix, which is neither hermetic nor useful. Along the way improve test coverage by parameterizing tests in the choice of `NestedSet` vs. list.
fmeum
requested review from
aranguyen and
justinhorvitz
and removed request for
a team and
aranguyen
github-actions
bot
added
team-Performance
...test/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLineTest.java
Outdated
Show resolved
Hide resolved
justinhorvitz
approved these changes
Dec 23, 2025
justinhorvitz
added
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
FileRootobjects were stringified to their absolute (!) path with aderived/sourcesuffix, which is neither hermetic nor useful.In the future, when path mapping is restricted to path stripping, which can be applied to prefixes of full exec paths without knowing the full path,
FileRootobjects can be path mapped automatically. Even before that happens, allowing users to e.g. doargs.add(ctx.bin_dir)avoids a gotcha and makes it easier to write code that can be path mapped in the future.Along the way improve test coverage by parametrizing tests in the choice of
NestedSetvs. list.