Skip to content

Consistently use regular inheritance in StarlarkInt #28079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fmeum wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Consistently use regular inheritance in StarlarkInt #28079

fmeum wants to merge 1 commit into from

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 22, 2025 •
edited
Loading

Previously this class mixed regular method overrides with manual instanceof dispatch, which resulted in a number of redundant toBigInteger() calls and generally made it harder to follow the different cases.
@fmeum
Consistently use regular inheritance in StarlarkInt
c7913fa 
Previously this class mixed regular method overrides with `instanceof` dispatch. Also seal the class hierarchy.
@fmeum fmeum marked this pull request as ready for review December 23, 2025 12:15
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 23, 2025
@iancha1992 iancha1992 added team-Starlark-Interpreter Issues involving the Starlark interpreter used by Bazel team-Performance Issues for Performance teams labels Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-Performance Issues for Performance teams team-Starlark-Interpreter Issues involving the Starlark interpreter used by Bazel

2 participants

@fmeum @iancha1992