Skip to content

[9.0.0] Enable --experimental_retain_test_configuration_across_testonly #28089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bazel-io wants to merge 1 commit into
base: release-9.0.0
Choose a base branch
from
Open

[9.0.0] Enable --experimental_retain_test_configuration_across_testonly #28089

bazel-io wants to merge 1 commit into from
+1 −1

Conversation

@bazel-io
Copy link
Member

@bazel-io bazel-io commented Dec 22, 2025

This avoids action conflicts when testonly non-test targets depend on test targets.

Until --incompatible_check_testonly_for_output_files is flipped, it is still possible to get action conflicts when a non-testonly target depends on an output file of a test. Since this can be fixed by adding the missing testonly annotation, this is only a minor concern.

Fixes #28056

Closes #28073.

PiperOrigin-RevId: 847892897
Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2

Commit bcd8bcb
@fmeum @bazel-io
Enable --experimental_retain_test_configuration_across_testonly
c8ec1d7 
This avoids action conflicts when `testonly` non-test targets depend on test targets.

Until `--incompatible_check_testonly_for_output_files` is flipped, it is still possible to get action conflicts when a non-`testonly` target depends on an output file of a test. Since this can be fixed by adding the missing `testonly` annotation, this is only a minor concern.

Fixes bazelbuild#28056

Closes bazelbuild#28073.

PiperOrigin-RevId: 847892897
Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2
@bazel-io bazel-io requested a review from a team as a code owner December 22, 2025 22:56
@bazel-io bazel-io added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Dec 22, 2025
@bazel-io bazel-io mentioned this pull request Dec 22, 2025
Open
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 22, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request changes the default value of the experimental_retain_test_configuration_across_testonly option in TestConfiguration.java from false to true. There were no review comments provided for these changes.
@iancha1992 iancha1992 enabled auto-merge December 23, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions

2 participants

@bazel-io @fmeum