Skip to content

created parser regression test for nested sublocations. #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TimothyStiles merged 4 commits into from
Oct 11, 2023
Merged

created parser regression test for nested sublocations. #385

TimothyStiles merged 4 commits into from
Oct 11, 2023

Conversation

@TimothyStiles
Copy link
Collaborator

@TimothyStiles TimothyStiles commented Oct 10, 2023 •
edited
Loading

Changes in this PR

I've added a regression test case for an issue with the genbank location parser parseLocation that I have yet to solve.

Why are you making these changes?

I'm hoping by sharing this test case I can have some help solving this issue. Without it being fixed we won't be able to parse refseq's human genome for instance.

Pre-merge checklist

All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.

  • New packages/exported functions have docstrings.
  • New/changed functionality is thoroughly tested.
  • New/changed functionality has a function giving an example of its usage in the associated test file. See primers/primers_test.go for what this might look like.
  • Changes are documented in CHANGELOG.md in the [Unreleased] section.
  • All code is properly formatted and linted.
  • The PR template is filled out.
@TimothyStiles TimothyStiles merged commit f2310db into main Oct 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the sublocation-regression branch October 11, 2023 21:39
@TimothyStiles TimothyStiles mentioned this pull request Oct 12, 2023
Closed
paleale pushed a commit to paleale/poly that referenced this pull request Dec 9, 2023
@TimothyStiles @abondrn @paleale
created parser regression test for nested sublocations. (bebop#385)
1b8e8be 
* created parser regression test for nested sublocations.

* integrating @abondrn's fix to genbank parser.

* fixed lint issues.

* added data for regression test.

Co-authored-by: Alex <abondarenko101@gmail.com>
Co-authored-by: Alex <abondrn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@TimothyStiles