Skip to content

patched genbank parser and builder to handle BASE COUNT. #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TimothyStiles merged 1 commit into from
Oct 12, 2023
Merged

patched genbank parser and builder to handle BASE COUNT. #386

TimothyStiles merged 1 commit into from
Oct 12, 2023

Conversation

@TimothyStiles
Copy link
Collaborator

@TimothyStiles TimothyStiles commented Oct 12, 2023 •
edited
Loading

Changes in this PR

I've patched the genbank parser and builder to handle the BASE COUNT line.

Why are you making these changes?

Not handling this breaks the parser and cases it to throw an error.

Are any changes breaking? (IMPORTANT)

NO.

Pre-merge checklist

All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.

  • New packages/exported functions have docstrings.
  • New/changed functionality is thoroughly tested.
  • New/changed functionality has a function giving an example of its usage in the associated test file. See primers/primers_test.go for what this might look like.
  • Changes are documented in CHANGELOG.md in the [Unreleased] section.
  • All code is properly formatted and linted.
  • The PR template is filled out.
@TimothyStiles TimothyStiles merged commit 2d5d8c4 into main Oct 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the base-count-patch branch October 12, 2023 21:00
paleale pushed a commit to paleale/poly that referenced this pull request Dec 9, 2023
@TimothyStiles @paleale
patched genbank parser and builder to handle BASE COUNT. (bebop#386)
3cbc69e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@TimothyStiles