Fix segfault on large number of properties #397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the sum of the numeric, string, symbolic and exotic props overflowed MAX_INT32, we could be allocating a too small of a region and end up with a segfault. Like in the fixed date parsing in case [1], check individual values against a reasonable max (100000000), and throw an out-of-memory exception before summing and letting them overflow. [1] bellard@030333c Fix: bellard#111
Closed
Contributor
Author
|
Better fix committed by Fabrice. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the sum of the numeric, string, symbolic and exotic props overflowed MAX_INT32, we could be allocating a too small of a region and end up with a segfault.
Like in the fixed date parsing in case 030333c, check individual values against a reasonable max (100000000), and throw an out-of-memory exception before summing and letting them overflow.
Fix: #111