Skip to content

Conversation

@bep
Copy link
Owner

@bep bep commented Nov 29, 2025

No description provided.

@bep bep force-pushed the deps/nov2025129 branch 2 times, most recently from a903562 to 0a2fcf1 Compare November 30, 2025 11:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates all direct dependencies, most notably upgrading AWS SDK v2 from v1.18.x to v1.40.0 and other packages. The code changes adapt to breaking changes in the newer AWS SDK API, particularly around endpoint configuration and pointer types.

Key changes:

  • Migrates from EndpointResolverWithOptions to BaseEndpoint in service client options for custom endpoint configuration
  • Adapts to AWS SDK v2's use of pointer types for fields like Size, IsTruncated, and ContentLength
  • Updates test to verify endpoint configuration at the service client level instead of AWS config level

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updates Go version to 1.24.0 (invalid) and upgrades all direct dependencies including AWS SDK v2, helpers, predicate, sync, and text packages
go.sum Updates checksums for all upgraded dependencies
lib/session.go Removes deprecated endpoint resolver code; endpoint configuration moved to service client creation
lib/s3.go Implements new BaseEndpoint pattern for S3 and CloudFront clients; adds nil checks for pointer types (Size, IsTruncated); wraps ContentLength with aws.Int64()
lib/session_test.go Refactors test to verify endpoint at service client level using newRemoteStore; more comprehensive test coverage
.github/workflows/test.yml Updates test matrix to Go 1.24.x and 1.25.x (invalid versions)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@bep bep merged commit 355ad26 into master Nov 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants