Skip to content

Improve error handling and prevent panics during file processing - #77

Merged
digizeph merged 3 commits into
mainfrom
dev
Sep 4, 2025
Merged

Improve error handling and prevent panics during file processing#77
digizeph merged 3 commits into
mainfrom
dev

Conversation

@digizeph

@digizeph digizeph commented Sep 4, 2025

Copy link
Copy Markdown
Member

Summary

  • Replace unwrap()/expect() calls with proper error handling throughout the codebase
  • Add clippy lints to prevent future panic-prone code
  • Fix network error handling in multi-file processing operations

Key Changes

  • Core library safety: All critical library functions now use Result types with descriptive error messages
  • Network resilience: Failed remote file downloads no longer crash the entire search process
  • Parallel processing: Individual file failures skip gracefully while other files continue processing
  • CI improvements: Added formatting and clippy checks to enforce code quality

Files Modified

  • Enhanced error handling in src/config.rs, src/database.rs, src/datasets/
  • Fixed network error panics in src/bin/monocle.rs
  • Updated CI workflow to include quality checks
  • Added clippy deny rules for unwrap_used and expect_used

Core library now passes clippy checks with no warnings and builds successfully.

Resolves #75

- Added clippy lints to deny unwrap_used and expect_used
- Updated configuration loading in src/config.rs to use Result types
- Fixed database operations in src/database.rs and src/datasets/as2org.rs
- Improved RPKI validator error handling in src/datasets/rpki/
- Enhanced time parsing with fallback values in src/time.rs
- Updated CI workflow to include formatting and clippy checks
- Core library now passes clippy --lib with no warnings
- Binary retains some unwraps for CLI error handling but core is safe
- Fixed panic when remote file download fails during search operations
- Replaced unwrap() with proper error handling in filters.to_parser() calls
- Failed files now log error and continue with remaining files in batch
- Parallel processing continues uninterrupted when individual files fail
- Resolves thread panic that caused entire search process to halt
@digizeph
digizeph merged commit 839e673 into main Sep 4, 2025
1 check failed
@digizeph
digizeph deleted the dev branch September 4, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant