Skip to content

Conversation

@Renerick
Copy link
Collaborator

@Renerick Renerick commented Dec 14, 2023

Description

I've removed all mentions of WS and SSE from core htmx.js, from the test server and also removed tests

Corresponding issue: 2.0 development 2.0

Probably could use a revision after merging #2025

Testing

I've checked that all tests (excluding removed ones) are 100% parsing. I also manually tested that all extension demos on the test server are working

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded
@Renerick Renerick changed the title Remove legacy WS/SSE code Dec 14, 2023
@Renerick Renerick changed the title [htmx 2.0] Remove legacy WS/SSE code Dec 14, 2023
@Renerick Renerick added the 2.0 label Dec 14, 2023
@Renerick
Copy link
Collaborator Author

Renerick commented Dec 14, 2023

After merging updated SSE implementation, it appears that it was a bit more reliant on legacy sse handling of triggers in the core, so I had to clean it up a bit, as well as removing legacy attributes handling from it. I think it's worth it to port some of those clean ups to 1.0 to make extension a bit more stable.

@1cg 1cg merged commit 2325637 into v2.0v2.0 Dec 14, 2023
@Renerick Renerick deleted the rip-legacy-ws-sse branch December 14, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants