docs: fix this binding in onClick .then handler with arrow function
#2373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe what changes you made, and why you feel they are necessary. Make sure to include
code examples, where applicable.
What
Update the
.then()handler in theonClickattribute to use an arrow function instead of a traditionalfunction(arg)expression.Why
The
windowscope was being accessed instead of the intendedbutton.This fixes the
thisbinding within the lexical scope, ensuring thatthisis bound to thebuttoninstead of thewindowand resolving the issue.Corresponding issue: #2257
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
Preview
The GIF demonstrates that clicking the button logs
thisto the console. The change ensures correctthisbinding, logging the specific button instead of the window.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded