Fix #2317 force conversion to FormData for xhr.send #2481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a
multipart/form-dataform, current implementation with the proxied FormData results in requests being malformed (wrong content type set totext/plain, FormData sent as[object FormData]in the payload)Couldn't get the proxy object to work properly with XMLHTTPRequest's
sendmethod; even though calls are being forwarded to the underlying FormData through the proxy, the request won't set its type tomultipart/form-datawhen appropriate and instead send atext/plainrequest.One simple fix/workaround here is to copy the values into a new, actual FormData (not a proxied one)
Corresponding issue:
#2317
Also see this JSFiddle to reproduce the issue
Testing
Didn't know how to add a reliable test for this tbh, given that we mock the requests in our test suite
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded