Add htmx4s to scala server-examples #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi, wondering if I forgot something to do or is there anything I can improve in order for it being considered? Thank you! 🙏🏼 |
Collaborator
|
Nope, totally forgot about it 😆 |
Telroshan
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi, I included my scala library to the examples section of the website (servers).
I did not run
npm run test, because it is only a documentation change.I did run
zola checkthat reported a list of broken links, but it didn't include this new one :-).Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded