Documentation 3xx redirects can't send headers #2904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Telroshan
requested changes
Sep 14, 2024
Collaborator
Telroshan
left a comment
Telroshan
left a comment
There was a problem hiding this comment.
Great addition for a very common gotcha!
www/content/docs.md
Outdated
| | `HX-Trigger` | the `id` of the triggered element if it exists | ||
|
|
||
| ### Response Headers | ||
| ### Response Headers {#response_headers} |
Collaborator
There was a problem hiding this comment.
This seems to break the default anchor that was response-headers and referenced at 2 other places in this file.
Ran zola serve and got 2 errors, I'd say either replace this by response-headers or replace the 2 existing usages by response_headers.
Collaborator
Author
There was a problem hiding this comment.
Yeah sorry I missed those two existing links. should be fixed now
Telroshan
approved these changes
Sep 15, 2024
Collaborator
|
Perfect thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some documentation for how response headers are not received or processed when 3xx response codes are returned.
Corresponding issue:
#2879
Testing
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded