Skip to content

Conversation

@scrhartley
Copy link
Contributor

Description

On the page Building htmx Extensions it includes an incomplete list of the extension points available to override. These are init, which I can see is used by official htmx extensions, and getSelectors which has a test covering its usage.

Testing

Coped from source code, which is already covered by tests.
I cross references this with how they're invoked to make sure I wasn't missing any parameters.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded
@Telroshan Telroshan added the documentation Improvements or additions to documentation label Nov 12, 2024
Copy link
Collaborator

@Telroshan Telroshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This was indeed an omission, thanks

@Telroshan Telroshan merged commit d39dd0e into bigskysoftware:master Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

2 participants