Skip to content

Add missing htmx:trigger event on load triggers #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1cg merged 1 commit into from
Dec 11, 2024
Merged

Add missing htmx:trigger event on load triggers #3033

1cg merged 1 commit into from
Dec 11, 2024

Conversation

@alexpetros
Copy link
Collaborator

@alexpetros alexpetros commented Nov 24, 2024

Description

The htmx:trigger event wasn't firing when the trigger was a load.

Testing

I added a new test for this scenario, verified that it passes for the fix, and that it doesn't pass without the fix.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded
@alexpetros alexpetros added the ready for review Issues that are ready to be considered for merging label Nov 24, 2024
@1cg 1cg merged commit bd35f64 into dev Dec 11, 2024
1 check passed
@alexpetros alexpetros deleted the trigger-fix branch November 22, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Issues that are ready to be considered for merging

3 participants

@alexpetros @1cg