Allow page description with default if missing #3150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjacksn
force-pushed
the
essay-descriptions
branch
from
68a9e5e to
df8e30e
Compare
If an essay has a description in the frontmatter, use that description in the `<meta name="description">` tag.
williamjacksn
force-pushed
the
essay-descriptions
branch
from
5e6878e to
c0f5ece
Compare
oliverhaas
pushed a commit
to oliverhaas/htmx
that referenced
this pull request
Jan 28, 2025
* Allow page description with default if missing If an essay has a description in the frontmatter, use that description in the `<meta name="description">` tag. * Add description to 10-tips-for-ssr-hda-apps * Add description to a-real-world-nextjs-to-htmx-port * Add description to a-real-world-react-to-htmx-port * Add description to a-real-world-wasm-to-htmx-port * Add description to a-response-to-rich-harris * Add description to alternatives * Add description to another-real-world-react-to-htmx-port
emilhem
pushed a commit
to emilhem/htmx
that referenced
this pull request
Feb 10, 2025
* Allow page description with default if missing If an essay has a description in the frontmatter, use that description in the `<meta name="description">` tag. * Add description to 10-tips-for-ssr-hda-apps * Add description to a-real-world-nextjs-to-htmx-port * Add description to a-real-world-react-to-htmx-port * Add description to a-real-world-wasm-to-htmx-port * Add description to a-response-to-rich-harris * Add description to alternatives * Add description to another-real-world-react-to-htmx-port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an essay has a description in the front matter, use that description in the
<meta name="description">tag.Testing
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded