Typo in addEventListener - use evt instead of event #3188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
addEventListener, when thetriggerSpec.changedif block was entered,nodewas being set toevent.target. This technically works, but is deprecated and should useevt.targetinstead like the rest ofaddEventListener.Corresponding issue: #3179
Testing
Smoke test a basic changed trigger flow.
/helloshould get called as expected (meaning thatnode, and thusnode.valueare still getting assigned as expected):Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded