Remove old IE support #3277
Merged
Remove old IE support #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelWest22
commented
Apr 17, 2025
| function matches(elt, selector) { | ||
| // @ts-ignore: non-standard properties for browser compatibility | ||
| // noinspection JSUnresolvedVariable | ||
| const matchesFunction = elt instanceof Element && (elt.matches || elt.matchesSelector || elt.msMatchesSelector || elt.mozMatchesSelector || elt.webkitMatchesSelector || elt.oMatchesSelector) |
Collaborator
Author
There was a problem hiding this comment.
all supported browsers have long since moved to support .matches in the last 10 years so we don't need this fallback now
MichaelWest22
commented
Apr 17, 2025
MichaelWest22
commented
Apr 17, 2025
src/htmx.js
Outdated
| return | ||
| } | ||
| // Ensure only valid Elements and not shadow DOM roots are inited | ||
| if (elt instanceof Element) return |
Collaborator
Author
There was a problem hiding this comment.
ensure only elements that can have attribute which need hashing and can have hx-attributes are processed to avoid processing shadow dom root nodes
MichaelWest22
commented
Apr 17, 2025
| } else if (console.log) { | ||
| console.log('ERROR: ', msg) | ||
| } | ||
| console.error(msg) |
Collaborator
Author
There was a problem hiding this comment.
console.error is standard in all supported browsers now
Telroshan
approved these changes
Apr 20, 2025
Collaborator
Telroshan
left a comment
Telroshan
left a comment
There was a problem hiding this comment.
Good riddance if you ask me!
Telroshan
added
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've looked at all cases of IE fallbacks that can be removed now that IE 11 is no longer supported by htmx 2.x.
I've included all possible old browser compatibility checks I could find but it may be possible to roll back some of these changes
As well as just safely removing dead un-needed fallbacks I also found three bugs that the removals have also forced me to address
1st is NormalizePath() which does not function at all as calling new URL(path) without an origin domain added as a second parameter is designed to throw errors every time causing the IE11 fallback to happen for ALL calls to normalizePath and this fallback does zero normalization. I don't think this lost functionality would have caused big issues as this function is only used to set and restore paths to history so even if it is broken it was consistently broken so broken paths going into history cache came out with the same non normalized path most of the time. After this change it normalizes properly again
2nd I found shadow dom tests were calling process/init node on the shadow dom root node itself which are not possible to init properly because this node can't have attributes. The IE fallback was preventing any errors but it was leaving rubbish htmx internal data on the shadow root nodes then. only processing elements resolved the shadow dom tests failing.
3rd there is a minor issue where after removing the IE fallback for if verifyPath() I found situations where new URL() will fail if things like srcdoc iframes have invalid origins. Found using window.origin as a fallback when these null origins from
about:protocol situations resolved the issue.Corresponding issue:
Testing
Performed extensive testing with the test suite and used my work on the loc coverage reporting to track down and test the dead branches.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded