Skip to content

Conversation

@MichaelWest22
Copy link
Collaborator

@MichaelWest22 MichaelWest22 commented Apr 21, 2025

Description

To allow loc coverage testing of hard reloads and refreshes I've proxied window.location into htmx.location that is used for .reload() and setting href. This can then be replaced if needed to allow full testing of the reload features and also this would allow future extensions to override page reloading if required.

Also found instances of document.location usage which should all be just location to minify code.

Corresponding issue:

Testing

Added new tests for HX-Refresh and HX-Redirect and history cache miss

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded
@Telroshan Telroshan added devops Changes to the repository structure or project management enhancement New feature or request ready for review Issues that are ready to be considered for merging labels Apr 22, 2025
@1cg 1cg merged commit d3bcd78 into bigskysoftware:dev Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops Changes to the repository structure or project management enhancement New feature or request ready for review Issues that are ready to be considered for merging

4 participants