Fix invisible button text for hx-indicator in dark mode #3353
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, in dark mode the [hx-indicator](https://htmx.org/attributes/hx-indicator/) demo button has white text on white background. Switching to `Canvas` means the button background will be black in dark mode. This is a similar fix to bigskysoftware#2719, though we can’t use `primary` here as it would make the indicator "bars.svg" image almost invisible.
tbrlpld
reviewed
Jun 27, 2025
| letter-spacing: .1em; | ||
| text-transform: uppercase; | ||
| background: white; | ||
| background: Canvas; |
There was a problem hiding this comment.
😳 what is "Canvas"? I tried to look for it on MDN but am coming up short.
Collaborator
There was a problem hiding this comment.
https://blog.jim-nielsen.com/2021/css-system-colors/
https://drafts.csswg.org/css-color/#css-system-colors
Hopefully it works in iOS now???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #1431. Without this, in dark mode the hx-indicator demo button has white text on white background. Switching to
Canvasmeans the button background will be black in dark mode.This is a similar fix to #2719, though we can’t use
primaryhere as it would make the indicator "bars.svg" image almost invisible.Testing
Switch between light and dark themes on hx-indicator. Quick recording of the "before" behavior, and the "after" in dark and light themes:
Checklist
masterfor website changes,devforsource changes)
approved via an issue
[ ] I ran the test suite locally (npm run test) and verified that it succeeded