handle custom element manual input value collection#3872
Open
MichaelWest22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix: FACE value not sent when used as standalone trigger (no form)
Form-associated custom elements (e.g. ) used as standalone htmx triggers outside a
stopped sending their value in beta4. This was a regression introduced by f02a86b ("Improve Non form input and checkbox handling").The fix adds a single else if branch in __addInputValues for elements whose tag name contains a hyphen (the W3C-mandated marker for all custom elements). These are routed through the existing loop the same way BUTTON is — inputs = [elt] — so they pick up the name/disabled/included guards and fall through to formData.append(input.name, input.value) without any duplicated logic.
The form path (new FormData(form)) is unaffected and continues to collect FACE values via setFormValue as before.
Corresponding issue:
#3871
Testing
Added tests for the new behaviour
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded