Add support for DDG ext device type - #8259
Draft
kspearrin wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-42510
📔 Objective
Adds
DeviceType.DuckDuckGoExtension = 27so DuckDuckGo can be identified as a browserextension client.
DuckDuckGo now exposes itself as a browser brand —
DuckDuckGoappears innavigator.userAgentData.brandsin both popup and service-worker contexts, and they setmatching
sec-ch-uaheaders during regular browsing. The browser variant(
DuckDuckGoBrowser = 26) already landed and covers the web vault case; this adds themissing extension variant.
Without it, a DDG extension client has no accurate device type to report and falls back to
ChromeExtension, mislabeling the device in device lists, new-device-login emails, 2FAemails, and TDE login-approval prompts.
📸 Screenshots
n/a