Skip to content

feat(sso): Add preferred algorithms to SP metadata - #8280

Open
enmande wants to merge 1 commit into
mainfrom
auth/pm-42628/advertise-oaep-in-acs
Open

feat(sso): Add preferred algorithms to SP metadata#8280
enmande wants to merge 1 commit into
mainfrom
auth/pm-42628/advertise-oaep-in-acs

Conversation

@enmande

@enmande enmande commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-42648

📔 Objective

  • Advertises OAEP encryption algorithms on SAML Service Provider (SP) metadata.

📸 Screenshots

N/A

@enmande enmande added needs-qa ai-review Request a Claude code review t:feature Change Type - Feature Development labels Aug 28, 2026
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the SAML SP metadata change: a MetadataCreated notification registered on Saml2Options that appends the accepted RSA-OAEP key-transport algorithms to every non-signing KeyDescriptor, the new SamlEncryptionAlgorithms constants, and the accompanying unit tests. GetSaml2AuthenticationScheme is the only construction site for Saml2Options in the repo, so every SAML scheme picks the handler up, and the subscription happens once per freshly built options instance — there is no repeated-subscription or accumulation path, and the new GetSchemeAsync test confirms the delegate survives PostConfigure. Both advertised algorithms are RSA-OAEP, which moves the SP off the PKCS#1 v1.5 default rather than toward a weaker one, and the ordering constraint that puts rsa-oaep-mgf1p first is documented at the constant and pinned by a literal-order test. Empty-descriptor, signing-only-key, and multiple-key cases are all covered, and CI (build, lint, tests) is green.

No findings met the bar for an inline comment.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.76%. Comparing base (7f38699) to head (5e2429a).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8280      +/-   ##
==========================================
- Coverage   68.57%   63.76%   -4.81%     
==========================================
  Files        2401     2431      +30     
  Lines      104043   104977     +934     
  Branches     9426     9509      +83     
==========================================
- Hits        71349    66942    -4407     
- Misses      30341    35719    +5378     
+ Partials     2353     2316      -37     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@enmande
enmande marked this pull request as ready for review August 28, 2026 19:14
@enmande
enmande requested a review from a team as a code owner August 28, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review needs-qa t:feature Change Type - Feature Development

2 participants