Skip to content

Implemented the onSuccess() callback#44

Open
Pasick wants to merge 4 commits into
bloomberg:mainfrom
Pasick:onsuccess-callback
Open

Implemented the onSuccess() callback#44
Pasick wants to merge 4 commits into
bloomberg:mainfrom
Pasick:onsuccess-callback

Conversation

@Pasick

@Pasick Pasick commented Jun 17, 2024

Copy link
Copy Markdown

Problem statement

Current implementation of rmqcpp library only provides a callback when the connection is broken. There is no callback which allows to detect when connection is restored to provide a more flexible way to monitor the connection state.

Proposed changes

The onSuccess() callback is raised on connection restore.

Remaining work

  • Unit Tests
  • Integration Tests
  • Documentation

@willhoy willhoy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@willhoy

willhoy commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

can you please sign your commit and we can get this merged thanks?

Learn more about signing commits.

@willhoy

willhoy commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

@Pasick, this is still waiting on [4b57d4a] (4b57d4a) to be signed

something like this should help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants