Remove BOOST_CONSTEXPR on BOOST_FUSION_DEFINE_STRUCT #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t however adds the requirement that the user provided types are constant enabled.
djowel
added a commit
that referenced
this pull request
Apr 21, 2015
Remove BOOST_CONSTEXPR on BOOST_FUSION_DEFINE_STRUCT
Collaborator
|
Thanks @daminetreg ! I didn't check other variations but is this enough? |
Contributor
Author
|
Compiled for me with the example of the list. Perhaps we have more work somewhere. |
Contributor
Author
|
But I couldn't find it out. |
Contributor
Author
|
@Flast I've let constexpr for empty struct, do you also think it's ok ? On line 290 https://github.com/boostorg/fusion/blob/master/include/boost/fusion/adapted/struct/detail/define_struct.hpp#L290 I think BOOST_FUSION_DEFINE_STRUCT_INLINE could also have problems. |
Collaborator
It seems good.
Sorry, I'm moving now and I can't ensure duration for investigating... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove BOOST_CONSTEXPR on BOOST_FUSION_DEFINE_STRUCT constructors as it however adds the requirement that the user provided types are constant enabled.
Relates to https://svn.boost.org/trac/boost/ticket/11211