Normalize resource dates as Time objects #1052
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: this _might_ impact anyone who's written code dealing with Date objects specifically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a confusing manner, the YAML importer was interpreting a variable like
date: 2025-10-25as aDateobject, whereasdate: 2025-10-25 10:11:12would be interpreted as aTimeobject. This resulted in resources in a collection having a mixture of Date and Time objects. Apparently some of the Active Support infrastructure loaded in under the hood was obfuscating these differences in terms of sort comparisons, but now as we migrate off of that it's revealing the gaps.This PR normalizes resource dates so that they're always
Timeobjects (the time of the date would be00:00:00aka 12:00AM). While that's a little confusing that the front matter key isdatebut the value is a Time object, I think it would be more confusing if we had usedtimein front matter (in the vernacular, people don't really think of times as having a date component).BREAKING CHANGE: this might impact anyone who's written code dealing with Date objects specifically.