Enforce minimum pperiod value in ensemble mttk#1144
Merged
brucefan1983 merged 2 commits intobrucefan1983:masterfrom Sep 10, 2025
Merged
Enforce minimum pperiod value in ensemble mttk#1144brucefan1983 merged 2 commits intobrucefan1983:masterfrom
mttk#1144brucefan1983 merged 2 commits intobrucefan1983:masterfrom
Conversation
| } else if (strcmp(params[i], "pperiod") == 0) { | ||
| if (!is_valid_real(params[i + 1], &p_period[0][0])) | ||
| PRINT_INPUT_ERROR("Wrong inputs for pperiod keyword."); | ||
| if (p_period[0][0] < 200) // Fix issue #1117 |
Owner
There was a problem hiding this comment.
and it is better to still use {} even if there is only one statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue #1117
Modification
a minimum
pperiodvalue is required:Others
The corresponding document has also incorporated this requirement.