Revert "temporarily remove C# variants runtime test (#963)" - #993
Merged
alexcrichton merged 2 commits intoJul 8, 2024
Merged
Conversation
Collaborator
Author
|
Regarding the CI failures: looks like some are flakes, but also the restored test is out-of-date with respect to the current binding generator. Serves me right for not testing locally, first. I'll push an update ASAP. |
dicej
force-pushed
the
restore-csharp-variants-test
branch
3 times, most recently
from
July 2, 2024 21:26
7cda06c to
9db504e
Compare
Collaborator
Author
|
I believe the remaining CI issue is unrelated to this PR. |
alexcrichton
approved these changes
Jul 8, 2024
alexcrichton
left a comment
alexcrichton
left a comment
Member
There was a problem hiding this comment.
CI should be fixed by #998 I think
Member
|
If you'd like to rebase I think this should be good to merge now |
…ce#963)" This reverts commit 3ca7739. As of dotnet/runtimelab#2609, the "return pointer not aligned" issue which forced us to remove the C# `variants` runtime test case _should_ be resolved. 🤞 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
force-pushed
the
restore-csharp-variants-test
branch
from
July 8, 2024 15:59
9db504e to
851b012
Compare
alexcrichton
enabled auto-merge
July 8, 2024 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3ca7739.
As of dotnet/runtimelab#2609, the "return pointer not aligned" issue which forced us to remove the C#
variantsruntime test case should be resolved. 🤞