Make ocaml-minisat friendly with continuous integration #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the case where we instanciate the counter in the for loop
for(int a; a<10; a++) {}
idiom
In this fix, I check that uint64 hasn't been defined yet using the ARCH_UINT64_TYPE flag.
|
I suppose I have to give access to travis for the CI, is that right? |
|
Yep! But I didn't actually prepare a |
|
If it doesn't bother you, I'd be thankful, yes. |
|
Done in PR #2! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you so much for this ocaml binding for minisat. I tweaked it in order to have a linux/windows/mac build that works on the project touist.
Edits for continous integration:
and replaced them by the actual files; I did that because
in cygwin, ocamlc wouldn't find solver.h in #include "solver.h".
I might be mistaken but it's the only thing I found to avoid the
problem...
In fact, the '#ifdef _WIN32' wasn't proper for cygwin builds;
plus, the uint64 isn't standard, changed to uint64_t.
See the SO topic here: http://stackoverflow.com/questions/126279