Skip to content

Conversation

@maelvls
Copy link
Collaborator

@maelvls maelvls commented Dec 30, 2018

Note that findlib isn't relevant anymore. As an example, oasis2opam
is not generating this file anymore: ocaml/opam#2948

@c-cube Do you think we should convert?

Note that findlib isn't relevant anymore. As an example, oasis2opam
is not generating this file anymore:

ocaml/opam#2948
@maelvls maelvls requested a review from c-cube December 30, 2018 17:17
Fdopen says on https://fdopen.github.io/opam-repository-mingw/:

> Upgrading an existing ~/.opam folder is not supported, just rename
> or delete the directory and let opam create a new one.
[ERROR] Could not synchronize C:/cygwin/home/appveyor/.opam/4.03.0+mingw32c/.opam-switch/sources/qbf from "git+file://C:/projects/ocaml-qbf#HEAD":
        "C:\\cygwin\\bin\\git.exe fetch -q" exited with code 128
[ERROR] Error getting source from git+file://C:/projects/ocaml-qbf#HEAD:
          - git+file://C:/projects/ocaml-qbf#HEAD
@c-cube
Copy link
Owner

c-cube commented Dec 30, 2018

Convert what? The opam file seems fine, but I think moving to dune will also be useful before making a new release.

@maelvls
Copy link
Collaborator Author

maelvls commented Jan 1, 2019

Hmm... I now realize that this PR doesn't make any sense, what is the rationale behind moving to the 2.0 format?

The actual reason why I opened the PR was rather to fix the issue I found when trying the opam publish command; it gives me the following:

> opam publish

[WARNING] Opam file /Users/mvalais/code/ocaml-qbf/opam/opam has 1.2 format,
          which is not accepted on 2.0 repository.
 Update it inplace to 2.0 format? [Y/n] y

The following will be published:
  - qbf version 0.3 with opam file at /Users/mvalais/code/ocaml-qbf/opam/opam
  - qbf version 0.3 with opam file at /Users/mvalais/code/ocaml-qbf/opam/opam

[ERROR] Multiple publications with the same name are not allowed

There might be a bug with opam publish (or I misinterpreted how to use it); as a workaround, I did

> mv opam/opam opam/qbf.opam
> opam publish
[WARNING] Opam file /Users/mvalais/code/ocaml-qbf/opam/qbf.opam has 1.2 format,
          which is not accepted on 2.0 repository.
 Update it inplace to 2.0 format? [Y/n] y

The following will be published:
  - qbf version 0.3 with opam file at
    /Users/mvalais/code/ocaml-qbf/opam/qbf.opam

[WARNING] These will be virtual packages: qbf.0.3

Continue ? You will be shown the patch before submitting. [Y/n]

or

> mv opam/ qbf.opam/
> opam publish
[WARNING] Opam file /Users/mvalais/code/ocaml-qbf/qbf.opam/opam has 1.2 format,
          which is not accepted on 2.0 repository.
 Update it inplace to 2.0 format? [Y/n] y

The following will be published:
  - qbf version opam with opam file at
    /Users/mvalais/code/ocaml-qbf/qbf.opam/opam

[WARNING] These will be virtual packages: qbf.opam

Continue ? You will be shown the patch before submitting. [Y/n]

Anyway, sorry for the inconvenience! We can still open a PR to https://github.com/ocaml/opam-repository directly without opam publish 🙂

@maelvls maelvls closed this Jan 1, 2019
@maelvls
Copy link
Collaborator Author

maelvls commented Jan 1, 2019

Btw, could I create a new tag 0.3 with the current master? So that it can be built with opam 2 🙂

@c-cube
Copy link
Owner

c-cube commented Jan 1, 2019

The rationale for moving to opam2 is that opam 1 is no longer supported, and that the repository uses version 2.0. But I can migrate it myself, no worries. Moving to dune would be more helpful I think.

@c-cube
Copy link
Owner

c-cube commented Feb 8, 2019

btw I think you didn't push the tag, I don't see it on github :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants