Skip to content

Conversation

@maelvls
Copy link
Collaborator

@maelvls maelvls commented Jan 7, 2021

At first, I just wanted to update and fix the .travis-ci.yml and appveyor.yml. And since I had already made the change to Github Actions on touist and ocamlyices2, I figured why not move ocaml-qbf to it too?

@maelvls maelvls force-pushed the move-to-github-actions branch from aaf63d3 to 3798be1 Compare January 7, 2021 17:10
@c-cube
Copy link
Owner

c-cube commented Jan 7, 2021

wait until #7 is merged, it disables these terrible warnings

@maelvls maelvls force-pushed the move-to-github-actions branch from 3798be1 to 4503bca Compare January 8, 2021 10:45
@c-cube c-cube force-pushed the move-to-github-actions branch from b39e099 to 1f323f8 Compare January 8, 2021 16:25
@c-cube
Copy link
Owner

c-cube commented Jan 8, 2021

I'm tired of this, will resume later unless you want to try and make it work

@maelvls
Copy link
Collaborator Author

maelvls commented Jan 8, 2021 via email

@maelvls
Copy link
Collaborator Author

maelvls commented Jan 8, 2021

Finallyyy it passes!! 🎉🎉

Edit: almost

@maelvls maelvls force-pushed the move-to-github-actions branch from ef3f834 to 5bc44d4 Compare January 9, 2021 17:46
@maelvls
Copy link
Collaborator Author

maelvls commented Jan 10, 2021

Yes! Now it works 😁

@maelvls maelvls force-pushed the move-to-github-actions branch from 79017a8 to 117de7a Compare January 10, 2021 18:00
maelvls and others added 12 commits January 10, 2021 19:19
Reasoning: I find it quite tricky/time consumming to maintain two
configurations for two separate CI providers.

Signed-off-by: Simon Cruanes <simon.cruanes.2007@m4x.org>
This is because Pervasives has been removed from the latest versions of
OCaml. Its replacement is Stdlib since 4.08.0.
I did that in order to aboid the annoying ld warning that says that
src/quantor was not found when building an executable that uses
ocaml-qbf.

I also made sure there is no (bash ...) which was causing issues on
Windows + Cygwin: the command (bash %{make}) was picking up the wrong
make binary.
@maelvls maelvls force-pushed the move-to-github-actions branch from 117de7a to 8ac24fa Compare January 10, 2021 18:20
@c-cube c-cube merged commit 3db82ac into master Jan 10, 2021
@c-cube c-cube deleted the move-to-github-actions branch January 10, 2021 19:45
@c-cube
Copy link
Owner

c-cube commented Jan 10, 2021

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants