Some test and general fixes #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arena was reused when it shouldn't after a Release() call.
In the future, it would be ideal if wrongful Release() calls could be flagged (either through an error or panic).
This moves the check for released messages earlier in the Release() call for transport messages. This prevents triggering the race detector, due to the check happening before an attempt is made at accessing the message (which involves indirection through a segment that may have been released already). While the prior code would not have actually caused a fault in current code (because the conditional checks both for the released flag and whether the message is nil), checking by the release flag first is more correct and may prevent future bugs.
Previously this was not enforced by the Encode function. While this limit is unlikely to be hit in practice, it's important to assert it due to the type allowing it and a count of segments greater than 2^32 causing an invalid marshaling.
lthibault
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #586.
That PR has uncovered more races, so I'm trying again with a different approach to eliminate them.
The commits that were unrelated to the actual refactor are in this PR to ease the future efforts.