feature(tabs): add new manual story#21624
Draft
heloiselui wants to merge 5 commits intocarbon-design-system:mainfrom
Draft
feature(tabs): add new manual story#21624heloiselui wants to merge 5 commits intocarbon-design-system:mainfrom
heloiselui wants to merge 5 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21624 +/- ##
==========================================
- Coverage 87.32% 87.29% -0.03%
==========================================
Files 538 538
Lines 43528 43528
Branches 6732 6698 -34
==========================================
- Hits 38010 37997 -13
- Misses 5356 5369 +13
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
heloiselui
added
status: visual review 🔍
package: @carbon/web-components
maradwan26
reviewed
Feb 23, 2026
Contributor
maradwan26
left a comment
maradwan26
left a comment
There was a problem hiding this comment.
This mostly looks good just one issue:
The arrow shows up on the left side when moving through the tabs:
Screen.Recording.2026-02-23.at.2.50.59.PM.mov
This happens in the Manual story too.
Comment on lines
+78
to
+80
| <div | ||
| class="${prefix}--tabs__nav-item--close--hidden" | ||
| aria-hidden="true"></div> |
Contributor
There was a problem hiding this comment.
I believe this is what's causing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19760
Sync WC Tab
DefaultandManualstory with ReactChangelog
New
ManualTabs story to WCChanged
Defaultstory to match React labels, selected value, panel structure, and tab content layoutvalidation exampleform styles in Tabs storiesRemoved
NoneTesting / Reviewing
WC Deploy Preview>Tabs>DefaultandManualstoriesNote
Please note that no props changed or added
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide