deps(tsdown): migrate monorepo build/bundling to tsdown#21659
deps(tsdown): migrate monorepo build/bundling to tsdown#21659kennylam wants to merge 25 commits intocarbon-design-system:mainfrom
tsdown#21659Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #21659 +/- ##
==========================================
+ Coverage 87.37% 93.99% +6.61%
==========================================
Files 538 537 -1
Lines 43505 43532 +27
Branches 6684 6279 -405
==========================================
+ Hits 38014 40916 +2902
+ Misses 5329 2467 -2862
+ Partials 162 149 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kennylam I worked with an agent on some approaches to diff this vs main and landed with some good intel. ResultI diffed generated artifacts across
Highest-risk differences
Notable broad churn (content changed)
Most of this is codegen/layout/runtime-wrapper churn, but the missing-file classes above are the likely consumer-breaking deltas. Thoughts
|
|
Also once we've got parity straightened out, I'd love to switch the ci here to the smaller/normal runner and see if the OOM issues are resolved at all. |
|
@tay1orjones Damn good catches. The one thing I did not do is consume this in any sort of standalone app. I'll look into the issues you mentioned.
This is actually intentional. The |
This migrates all build and bundling workflows from Rollup to tsdown. Previously project builds averaged 2m50s. With tsdown, the average (on my computer) is just over 1 minute, a reduction of ~63%.
Changelog
New
tsdownadded as build/bundler for all packagesChanged
package.jsonbuild scriptsbuild:cdnnow runs in CI/CD onlyRemoved
react-routerexample since this exists inreact-router-viteTesting / Reviewing
The project should build with no errors. All CI tests and checks should pass. No visual changes were made.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)More details can be found in the pull request guide