refactor(react): use usePrefix in Slider and SliderHandles#21678
refactor(react): use usePrefix in Slider and SliderHandles#21678adamalston wants to merge 4 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21678 +/- ##
==========================================
- Coverage 87.54% 87.48% -0.07%
==========================================
Files 538 538
Lines 43486 43483 -3
Branches 6651 6644 -7
==========================================
- Hits 38071 38040 -31
- Misses 5254 5282 +28
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tay1orjones
left a comment
There was a problem hiding this comment.
@adamalston it looks like the missing test coverage is isolated around twoHandles && isRtl
Not necessary to merge but a heads up if you wanted to fix.
|
I think the coverage report is highlighting unreachable code in this section: carbon/packages/react/src/components/Slider/Slider.tsx Lines 1545 to 1577 in 69db878 This block is gated by
|
|
Re-requesting reviews since code has changed. These changes will conflict with #21673 and possibly other pull requests. |
Partially addresses #18868
Used
usePrefixinSliderandSliderHandles.Changelog
Changed
usePrefixinSlider.usePrefixinSliderHandles.Testing / Reviewing
These components appeared to be the last ones in the codebase still using the
PrefixContext.Consumerconstruct.Existing tests should cover these changes.
yarn test --coverage \ --runTestsByPath packages/react/src/components/Slider/__tests__/Slider-test.js \ --collectCoverageFrom=packages/react/src/components/Slider/Slider.tsxPR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide