Skip to content

Conversation

@yoshuawuyts
Copy link
Member

Adds a contributing file, and code of conduct as per choojs/discuss#5. Hope this good; please do give it a read. Thanks!

Todo

@toddself
Copy link
Contributor

Should we have more than one maintainer listed I think in case there are issues with the maintainer listed?

I like the examples section since it helps clarify the course of action.

@lrlna
Copy link
Member

lrlna commented Oct 20, 2017

what @toddself said! might also be helpful if you're away etc. i heard its good to have an un-even number in case you need to take a vote / reach consensus on an issue.

otherwise looks good! glad you decided to adopt the WeAllJs version!

@yoshuawuyts
Copy link
Member Author

@lrlna @toddself can I pencil the both of you in then?

@lrlna
Copy link
Member

lrlna commented Oct 22, 2017 via email

@yoshuawuyts
Copy link
Member Author

Hmmm, we never ended up merging this. Think the wording in this CoC is not ideal tbh.

Using contributor covenant might make a bit more sense for us? Better understood, and probably easier to follow. Example: https://github.com/choojs/bankai/blob/f7d988e0ab609a83a11f90389f0fa0765167b677/.github/CODE_OF_CONDUCT.md

@lrlna
Copy link
Member

lrlna commented Feb 1, 2018 via email

@yoshuawuyts
Copy link
Member Author

@lrlna I made a Frankenstein edited version of a different CoC. The Contributor Covenant is nice & to the point; good enough that people might actually read the thing.

@lrlna
Copy link
Member

lrlna commented Feb 2, 2018

@yoshuawuyts gotcha!

@ungoldman
Copy link
Member

+1 for contributor covenant, it's well known, well documented, and versioned. Easy to link to in contributing docs or copy to a CODE_OF_CONDUCT.md file. That's what I've done in the past for other projects :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants