Skip to content

Refactor s:TmuxCommand, add s:GetTmuxCommand #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor s:TmuxCommand, add s:GetTmuxCommand #200

wants to merge 2 commits into from

Conversation

@blueyed
Copy link
Collaborator

@blueyed blueyed commented Apr 30, 2018

  • use a list instead of single string
  • add s:GetTmuxCommand to be used later when not using system() only
  • remove :silent when calling tmux from s:TmuxAwareNavigate: it
    should not be necessary and is bad practice to use :silent
    unnecessarily. It was added in b068a04 with no explanation.
@blueyed
Refactor s:TmuxCommand, add s:GetTmuxCommand
1ce6c32 
- use a list instead of single string
- add s:GetTmuxCommand to be used later when not using `system()` only
- remove `:silent` when calling tmux from `s:TmuxAwareNavigate`: it
  should not be necessary and is bad practice to use `:silent`
  unnecessarily.  It was added in b068a04 with no explanation.
@blueyed blueyed mentioned this pull request Apr 30, 2018
Closed
2 tasks
@christoomey
Copy link
Owner

christoomey commented May 3, 2018 •
edited
Loading

Broadly these changes all look good to me, but unfortunately I'm getting an error when running with this locally:

Error detected while processing function <SNR>151_TmuxWinCmd[2]..<SNR>151_TmuxAwareNavigate[23]..<SNR>151_TmuxCommand:
line    2:
E730: using List as a String

Any thoughts on what the issue might be?

Adding a bit more detail, I'm able to move between Vim panes, but hit the above error when attempting to navigate from Vim -> tmux.
@blueyed
Copy link
Collaborator Author

blueyed commented May 16, 2018

@christoomey
The problem is that Vim's system() does not handle lists for the command/argv. Will fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@blueyed @christoomey