Add MySQL support to certdb - #562
Merged
Merged
Conversation
Contributor
Author
| @@ -0,0 +1,24 @@ | |||
| Copyright (c) 2014 CloudFlare Inc. | |||
Contributor
There was a problem hiding this comment.
Is this the right LICENSE file?
Contributor
Author
There was a problem hiding this comment.
Nice catch, I updated gvt and it solved the problem.
Contributor
|
@drcapulet just an FYI, currently reviewing this. It's taking a while as there's a lot of vendored code to read through. |
Contributor
Author
|
@kisom Awesome, thanks! |
Contributor
|
LGTM,. |
|
any idea when this will be merged? we would really like to see cfssl support mysql since it will be easier to stand up a clustered implementation this way using mariadb. |
Contributor
|
LGTM, so the SQL statements we put down works with mysql as well? I am happy and feeling unreal. |
Contributor
|
still have conflicts though |
Contributor
|
@deanefrati @drcapulet Once this is rebased, it can be merged. |
Contributor
Author
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.