Skip to content

Cache integration tests and fix watch-mode inputs - #385

Draft
Maximo-Guk wants to merge 1 commit into
mainfrom
integration-tests-cache
Draft

Cache integration tests and fix watch-mode inputs#385
Maximo-Guk wants to merge 1 commit into
mainfrom
integration-tests-cache

Conversation

@Maximo-Guk

@Maximo-Guk Maximo-Guk commented Aug 28, 2026

Copy link
Copy Markdown
Member

Caches build:integration-worker and the integration test task. The suite tracks the prebuilt .wrangler/validate tree rather than excluding it, since that tree is the only path by which backend source reaches it.

@github-actions github-actions Bot added the kernel Changes to the Workshop kernel label Aug 28, 2026
@Maximo-Guk
Maximo-Guk force-pushed the integration-tests-cache branch from d335aef to 3f43b1f Compare August 28, 2026 22:04
@github-actions

Copy link
Copy Markdown

Preview: pr385-integration-t-72da5f96

https://pr385-integration-t-72da5f96-router.cloudflare-os-previews.workers.dev

Dashboard · deleted when this PR closes

@ask-bonk

ask-bonk Bot commented Aug 28, 2026

Copy link
Copy Markdown
  • P2 packages/integration-tests/src/global-setup.ts:45: An unrelated partial rerun within the 200 ms debounce unconditionally cancels a pending deletion-triggered full-suite rerun. The Worker rebuilds, but most tests never run against it. Only cancel when the current rerun covers the full suite.

github run

`build:integration-worker` and the integration `test` task both cache now.
The suite tracks the prebuilt `.wrangler/validate` tree instead of excluding
it -- that tree is the only path by which backend source reaches this suite.

Watch mode's hand-maintained path list becomes one table in
`src/worker-inputs.ts`, behind the watcher roots, `forceRerunTriggers` and a
new delete handler (vitest's `onFileDelete` never consults the triggers).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Maximo-Guk
Maximo-Guk force-pushed the integration-tests-cache branch from 3f43b1f to 675d259 Compare August 30, 2026 18:43
@ask-bonk

ask-bonk Bot commented Aug 30, 2026

Copy link
Copy Markdown
  • P2 packages/integration-tests/src/global-setup.ts:78: rerunTestSpecifications() invokes onTestsRerun before waiting for the active run, so the handler can destructively rebuild .wrangler/validate while existing tests still load it. Await vitest.waitForTestRunEnd() before triggering the rerun.

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Changes to the Workshop kernel

1 participant