fix(addressing): restore regional_hostnames sub-resource - #2731
Merged
Conversation
The regional_hostnames sub-resource was incorrectly removed in a curated sync (923e0c4). The upstream aggregate schema and Stainless codegen (stainless-sdks/cloudflare-python generated branch) both have these endpoints. This restores the resource, types, and tests as-is from the generated branch. Restored: - addressing.regional_hostnames (create, list, delete, edit, get) - addressing.regional_hostnames.regions (list) - All associated param/response types - Tests for both resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the
addressing.regional_hostnamessub-resource that was incorrectly removed.Context
The upstream aggregate schema (
api-schemasmain) and Stainless codegen (stainless-sdks/cloudflare-pythongenerated+mainbranches) both have these endpoints. The TypeScript SDK was never affected -- only the Python SDK lost the resource.What's restored
client.addressing.regional_hostnames(create, list, delete, edit, get)client.addressing.regional_hostnames.regions(list)RegionalHostnameCreateParams,RegionalHostnameCreateResponse, etc.)All files are taken as-is from the
stainless-sdks/cloudflare-pythongeneratedbranch -- no manual modifications.Verification
regional_hostnames(line 3521 inopenapi.stainless.yml)mainandgeneratedinstainless-sdks/cloudflare-python