feat!: remove xs size variant from form and action components - #701
Draft
FBalint wants to merge 1 commit into
Draft
feat!: remove xs size variant from form and action components#701FBalint wants to merge 1 commit into
FBalint wants to merge 1 commit into
Conversation
commit: |
Removes the 'xs' size variant from Button, Input, InputArea, InputGroup, Select, Combobox, Autocomplete, SensitiveInput, and Toolbar. Both the type unions and the runtime KUMO_*_VARIANTS.size entries are gone. Passing size='xs' will fail TypeScript compilation. Text keeps xs (it is a real typographic step, 12px). Banner: a size='sm' Banner used to render its Banner.Action children at xs (h-5). It now renders them at sm (h-6.5). BannerActionSize is narrowed to just 'sm'. Migration: find/replace size='xs' -> size='sm'.
FBalint
force-pushed
the
balint/remove-xs-components
branch
from
August 5, 2026 13:32
dea2abe to
7891cad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes N/A — proactive API cleanup.
Removes xs from Button, Input, InputArea, InputGroup, Select, Combobox, Autocomplete, SensitiveInput, Toolbar. Types and runtime, both gone.
Breaking change, major bump.
Why
xs on interactive controls produced sub-24px hit targets. Rarely the right call, but easy to reach for.
Considered a soft-deprecation route (JSDoc + registry-driven lint rule for value-level deprecations, TS itself can't do this). Prototyped it, decided the "supported but discouraged" middle state and the extra codegen/lint machinery weren't worth it over just removing.