[kumo] Fix InputGroup accessible-name warning - #761
Open
ftzi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The documented
<InputGroup label="Search">composition gives its input an accessible name but still emits[Kumo Input]: Input must have an accessible namein development.InputGrouprenders the parent label throughField, whileInputGroup.Inputdelegates toInput. The inner validator sees only naming props passed directly to the input, so it misses the valid label supplied by the group.Solution
aria-labelledbyonly when the input has no explicitaria-labeloraria-labelledby.<InputGroup><InputGroup.Input /></InputGroup>.@cloudflare/kumo.Validation
node_modules/.bin/vp run --filter @cloudflare/kumo test: 52 files and 1,277 tests passed, including 95 InputGroup tests.node_modules/.bin/vp run test:ci: 9 tests passed.node_modules/.bin/vp run build:kumo: passed.node_modules/.bin/vp exec tsx ci/scripts/validate-kumo-changeset.ts: passed.AI disclosure
This change and pull request description were prepared by an AI coding agent at the contributor's direction.